Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecations cleanup - Jandex, OpenTelemetry, SRye reactive messaging #32792

Merged
merged 4 commits into from
Apr 25, 2023
Merged

Deprecations cleanup - Jandex, OpenTelemetry, SRye reactive messaging #32792

merged 4 commits into from
Apr 25, 2023

Conversation

rsvoboda
Copy link
Member

  • Reactive messaging - SRye Channel and Emitter leftovers, switch to MP based annotations
  • OpenTelemetry - WithSpan and SpanAttribute deprecated package switch
  • Jandex related - Replace deprecated WildcardType.create with createUpperBound and createLowerBound
  • Jandex related - Replace deprecated ArrayType.component() with ArrayType.constituent()

@quarkus-bot
Copy link

quarkus-bot bot commented Apr 20, 2023

/cc @Sanne (hibernate-orm), @brunobat (opentelemetry), @gsmet (hibernate-orm,hibernate-search), @radcortez (opentelemetry), @yrodiere (hibernate-orm,hibernate-search)

@github-actions
Copy link

github-actions bot commented Apr 20, 2023 •
edited
Loading

🙈 The PR is closed and the preview is expired.

@quarkus-bot
Copy link

quarkus-bot bot commented Apr 20, 2023

Failing Jobs - Building 63d6a0a

Status Name Step Failures Logs Raw logs
✔️ JVM Tests - JDK 11
✖ JVM Tests - JDK 17 Build Failures Logs Raw logs
✔️ JVM Tests - JDK 19

Failures

⚙️ JVM Tests - JDK 17 #

- Failing: integration-tests/container-image/maven-invoker-way

📦 integration-tests/container-image/maven-invoker-way

✖ Failed to execute goal org.apache.maven.plugins:maven-invoker-plugin:3.5.1:run (integration-tests) on project quarkus-integration-test-container-image-invoker: 1 build failed. See console output above for details.

@rsvoboda
Copy link
Member Author

rsvoboda commented Apr 20, 2023 •
edited
Loading

integration-tests/container-image/maven-invoker-way fails with env related issue

[io.quarkus.container.image.jib.deployment.JibProcessor] I/O error for image [registry.access.redhat.com/ubi8/openjdk-11-runtime]:
[io.quarkus.container.image.jib.deployment.JibProcessor]     java.net.SocketTimeoutException
[io.quarkus.container.image.jib.deployment.JibProcessor]     Read timed out

brunobat
brunobat approved these changes Apr 21, 2023
View reviewed changes
Copy link
Contributor

@brunobat brunobat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doc changes for OTel look good

Ladicek
Ladicek approved these changes Apr 21, 2023
View reviewed changes
Copy link
Contributor

@Ladicek Ladicek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Jandex changes look good.

Specifically for the ArrayType.constituent() method, I hoped that people who are familiar with the respective part of the code would eventually see that component() is deprecated and figure out that they really should use either elementType() or componentType(), but this is OK too :-)

@gsmet gsmet merged commit 128b467 into quarkusio:main Apr 25, 2023
@quarkus-bot quarkus-bot bot added this to the 3.1 - main milestone Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brunobat brunobat brunobat approved these changes

@Ladicek Ladicek Ladicek approved these changes

@ozangunalp ozangunalp Awaiting requested review from ozangunalp

Assignees
No one assigned
Labels
area/arc Issue related to ARC (dependency injection) area/core area/documentation area/hibernate-orm Hibernate ORM area/hibernate-search Hibernate Search area/hibernate-validator Hibernate Validator area/persistence OBSOLETE, DO NOT USE area/reactive-messaging area/rest area/security area/smallrye area/spring Issues relating to the Spring integration area/tracing area/vertx
Projects
None yet
Milestone
3.1.0.CR1
Development

Successfully merging this pull request may close these issues.
4 participants
@rsvoboda @Ladicek @brunobat @gsmet